Prepare Production, and make Staging private#236
Prepare Production, and make Staging private#236dpordomingo merged 3 commits intosrc-d:release/v0.1from
Conversation
dpordomingo
left a comment
There was a problem hiding this comment.
@rporres PTAL
| prefix: PROD | ||
| secrets: [ PROD_API_SERVER, PROD_KUBERNETES_TOKEN ] | ||
| values: ingress.globalStaticIpName=code-annotation-production,ingress.hostname=code-annotation.sourced.tech,image.tag=${DRONE_TAG},deployment.gaTrackingID=UA-109494282-2,secretName=code-annotation-drone-workaround | ||
| values: ingress.globalStaticIpName=code-annotation-production,ingress.hostname=code-annotation.srcd.run,image.tag=${DRONE_TAG},deployment.gaTrackingID=UA-109494282-2,secretName=code-annotation-drone-workaround |
There was a problem hiding this comment.
is this conf compatible @rporres ?
ingress.globalStaticIpName=code-annotation-production
ingress.hostname=code-annotation.srcd.run
I'm not sure if we should use a new globalStaticIpName suffixed as -production while we're having a hostname following the staging pattern.
Is this something I should care about?
Does it affect the place where you store the secrets and these configurations?
(most probably I'm mixing concepts, so please ping me when you have time to explain it to me irl 💃 )
There was a problem hiding this comment.
Please use code-annotation-production.srcd.run as hostname. The rest is ok
There was a problem hiding this comment.
But that's the hostname defined by @mcuadros in the GH OAuth App as he wrote at #217 (comment)
Should we ask him to change it?
There was a problem hiding this comment.
d'oh, ok. I don't like that name, but I guess it's late to change it. I will change it on my side...
There was a problem hiding this comment.
LGTM. Let's wait for @rporres feedback as well.
Only App team members will be able to login to staging now.
I guess we just need to make sure that on production, same users as before would be able to log in, and see their previous answers.
|
Since the staging DB will be copied to production, all workers will keep their previous work already done in Staging. Does it answer your questions @bzz ? |
| prefix: PROD | ||
| secrets: [ PROD_API_SERVER, PROD_KUBERNETES_TOKEN ] | ||
| values: ingress.globalStaticIpName=code-annotation-production,ingress.hostname=code-annotation.sourced.tech,image.tag=${DRONE_TAG},deployment.gaTrackingID=UA-109494282-2,secretName=code-annotation-drone-workaround | ||
| values: ingress.globalStaticIpName=code-annotation-production,ingress.hostname=code-annotation.srcd.run,image.tag=${DRONE_TAG},deployment.gaTrackingID=UA-109494282-2,secretName=code-annotation-drone-workaround |
There was a problem hiding this comment.
Please use code-annotation-production.srcd.run as hostname. The rest is ok
After preparing Production environment #218 , some other changes must be done to: