Remove unused methods re: ReversalIndexServices - #1136
Merged
Merged
Conversation
Clarify that GetOrCreateRiGuidForWs gets or creates a Reversal Index, not a Writing System.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1136 +/- ##
=======================================
Coverage 38.68% 38.68%
=======================================
Files 1516 1516
Lines 351405 351372 -33
Branches 40421 40418 -3
=======================================
+ Hits 135929 135930 +1
+ Misses 186254 186224 -30
+ Partials 29222 29218 -4
🚀 New features to boost your workflow:
|
papeh
marked this pull request as ready for review
September 11, 2026 19:50
thejambi
approved these changes
Sep 11, 2026
thejambi
left a comment
Contributor
There was a problem hiding this comment.
@thejambi reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on papeh).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is
on Devin