close
Skip to content

Remove unused methods re: ReversalIndexServices - #1136

Merged
papeh merged 4 commits into
mainfrom
feature/clean-up-dead-code
Sep 11, 2026
Merged

papeh merged 4 commits into
mainfrom
feature/clean-up-dead-code

Conversation

@papeh

@papeh papeh commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

This change is Reviewable on Devin

@github-actions

Copy link
Copy Markdown

NUnit Tests

    1 files  ±0      1 suites  ±0   12m 56s ⏱️ +7s
6 084 tests ±0  5 999 ✅ ±0  85 💤 ±0  0 ❌ ±0 
6 093 runs  ±0  6 008 ✅ ±0  85 💤 ±0  0 ❌ ±0 

Results for commit 86cb410. ± Comparison against base commit cbb5dc2.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.68%. Comparing base (cbb5dc2) to head (86cb410).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1136   +/-   ##
=======================================
  Coverage   38.68%   38.68%           
=======================================
  Files        1516     1516           
  Lines      351405   351372   -33     
  Branches    40421    40418    -3     
=======================================
+ Hits       135929   135930    +1     
+ Misses     186254   186224   -30     
+ Partials    29222    29218    -4     
Files with missing lines Coverage Δ
Src/xWorks/FwXWindow.cs 11.71% <ø> (+0.25%) ⬆️
Src/xWorks/ReversalIndexServices.cs 72.85% <100.00%> (+1.06%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@papeh
papeh marked this pull request as ready for review September 11, 2026 19:50

@thejambi thejambi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@thejambi reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on papeh).

@papeh
papeh merged commit c96c131 into main Sep 11, 2026
9 checks passed
@papeh
papeh deleted the feature/clean-up-dead-code branch September 11, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants