Fix node positional information for files with single-quotes in comments#164
Merged
shellscape merged 8 commits intoshellscape:masterfrom Oct 9, 2021
nwalters512:fix/invalid-location-with-single-quote-comments
Merged
Fix node positional information for files with single-quotes in comments#164shellscape merged 8 commits intoshellscape:masterfrom nwalters512:fix/invalid-location-with-single-quote-comments
shellscape merged 8 commits intoshellscape:masterfrom
nwalters512:fix/invalid-location-with-single-quote-comments
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Owner
Contributor
Author
|
@shellscape do you have a rough estimate of when this will be released in a new version on npm? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This resolves issue #163.
Please check one:
This PR:
This PR is my attempt at resolving the issue described in #163. It makes the new tests I added pass, and it doesn't break any existing tests. Unfortunately, most of the existing tests don't assert anything about positional information, so it's pretty difficult for me to assert that this doesn't adversely impact anything else. I'd be happy to augment some existing tests with positional information to help increase confidence.
The change to
lib/nodes/inline-comment.jswas necessary to get the following assertion about the end position of a comment to pass: