close
Skip to content

data metrics v2: add rate metrics#884

Merged
majewsky merged 1 commit into
masterfrom
data-metrics-v2-phase5
May 12, 2026
Merged

data metrics v2: add rate metrics#884
majewsky merged 1 commit into
masterfrom
data-metrics-v2-phase5

Conversation

@majewsky
Copy link
Copy Markdown
Contributor

I adjusted the testcases to rename xOtherRate to a more plausible name to make the testcase more readable.

@majewsky majewsky requested a review from a team as a code owner May 11, 2026 11:00
@github-actions
Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/sapcc/limes/internal/api 78.88% (ø)
github.com/sapcc/limes/internal/api/api_v2 74.81% (ø)
github.com/sapcc/limes/internal/collector 83.37% (+0.36%) 👍
github.com/sapcc/limes/internal/core 78.23% (+0.40%) 👍
github.com/sapcc/limes/internal/db 73.75% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/sapcc/limes/internal/api/api_v2/info.go 92.86% (ø) 686 637 49
github.com/sapcc/limes/internal/api/rate_updater.go 47.19% (ø) 623 294 329
github.com/sapcc/limes/internal/collector/metrics.go 87.86% (+0.39%) 3633 (+448) 3192 (+406) 441 (+42) 👍
github.com/sapcc/limes/internal/core/config.go 100.00% (+4.82%) 581 581 (+28) 0 (-28) 👍
github.com/sapcc/limes/internal/db/models.go 100.00% (ø) 78 78 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/sapcc/limes/internal/collector/quota_overrides_test.go
  • github.com/sapcc/limes/internal/collector/scrape_test.go

VoigtS
VoigtS previously approved these changes May 12, 2026
Copy link
Copy Markdown
Member

@VoigtS VoigtS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good to me, I only have a small remark on the ServiceRateLimitConfiguration method comments.

Comment thread internal/core/config.go Outdated
@majewsky majewsky merged commit 33bf4e1 into master May 12, 2026
3 checks passed
@majewsky majewsky deleted the data-metrics-v2-phase5 branch May 12, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants