require resources.topology and rates.topology to be filled#880
Merged
Conversation
This was not upheld in some test scenarios, which might cause confusion down the line.
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
wagnerd3
approved these changes
May 5, 2026
Contributor
wagnerd3
left a comment
There was a problem hiding this comment.
Lucky you, I just recently introduced the fallback to FlatTopology on app layer with the changing-units PR 😄 https://github.com/sapcc/limes/blob/master/internal/core/cluster.go#L703
I think this should be safe to rollout without migrating any data, as the limit-only rates are always written on startup and should have been migrated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was not upheld in some test scenarios, which might cause confusion down the line.