close
Skip to content

require resources.topology and rates.topology to be filled#880

Merged
majewsky merged 1 commit into
masterfrom
liquid-scrape-refactor-phase2
May 5, 2026
Merged

require resources.topology and rates.topology to be filled#880
majewsky merged 1 commit into
masterfrom
liquid-scrape-refactor-phase2

Conversation

@majewsky
Copy link
Copy Markdown
Contributor

@majewsky majewsky commented May 5, 2026

This was not upheld in some test scenarios, which might cause confusion down the line.

This was not upheld in some test scenarios, which might cause confusion
down the line.
@majewsky majewsky requested a review from a team as a code owner May 5, 2026 09:41
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/sapcc/limes/internal/collector 83.52% (ø)
github.com/sapcc/limes/internal/db 81.29% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/sapcc/limes/internal/db/migrations.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/sapcc/limes/internal/collector/capacity_scrape_test.go
  • github.com/sapcc/limes/internal/collector/scrape_test.go

Copy link
Copy Markdown
Contributor

@wagnerd3 wagnerd3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lucky you, I just recently introduced the fallback to FlatTopology on app layer with the changing-units PR 😄 https://github.com/sapcc/limes/blob/master/internal/core/cluster.go#L703

I think this should be safe to rollout without migrating any data, as the limit-only rates are always written on startup and should have been migrated.

@majewsky majewsky merged commit 3d1e141 into master May 5, 2026
6 checks passed
@majewsky majewsky deleted the liquid-scrape-refactor-phase2 branch May 5, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants