RenderMailTemplate: change endpoint permission#878
Conversation
85f7c77 to
4371ce0
Compare
wagnerd3
left a comment
There was a problem hiding this comment.
I just realized that cluster:show_basic is used in the old world to give simple project members access to cluster level access and not just to cloud_ roles.
A nicer way would be to pick up the permission scheme for the v2 API and introduce a policy for v2:cluster:admin and define this to match also the limes-validation user we have for this smoke testing. Let's discuss offline.
|
the policy now uses the v2:cluster:validation from the proposal: sapcc/helm-charts#11513 |
wagnerd3
left a comment
There was a problem hiding this comment.
We need to wait for the chart PR before merging.
majewsky
left a comment
There was a problem hiding this comment.
please adjust docs/example-policy.json to document this policy
the smoke-test user only has show_basic permissions, which conflicts with this endpoint. Instead of granting the user more permissions, the endpoint permission gets changed instead.
cb178e8 to
26af7bb
Compare
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
the smoke-test user that is used in the pipeline only has
show_basicpermissions, which conflicts with this endpoint. Instead of granting the user more permissions, the endpoint permission gets changed instead.