close
Skip to content

snippet edit support no longer experimental#22088

Open
BenjaminBrienen wants to merge 1 commit intorust-lang:masterfrom
BenjaminBrienen:snippet-edit-support
Open

snippet edit support no longer experimental#22088
BenjaminBrienen wants to merge 1 commit intorust-lang:masterfrom
BenjaminBrienen:snippet-edit-support

Conversation

@BenjaminBrienen
Copy link
Copy Markdown
Contributor

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 19, 2026
@ChayimFriedman2
Copy link
Copy Markdown
Contributor

The switch from SnippetCap is wrong, IMO. It makes things less type-safe.

@A4-Tacks
Copy link
Copy Markdown
Member

I don't think replacing SnippetCap with bool is a good idea, typed programming helps us avoid making mistakes

@BenjaminBrienen
Copy link
Copy Markdown
Contributor Author

I thought that making it a boolean would bring it in-line with all the other capability switches.

@ChayimFriedman2
Copy link
Copy Markdown
Contributor

Given that we already have it typed, I'd prefer that we don't do that. We can make the other options typed, if you want.

@BenjaminBrienen
Copy link
Copy Markdown
Contributor Author

I split SnippetCap into Workspace and Completion variants because they are actually based on two different things and avoiding mixing them using the type system seems like it would be the "whole point", so to speak.

@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@BenjaminBrienen
Copy link
Copy Markdown
Contributor Author

I'm sorry that the Uri migration is mixed in

@BenjaminBrienen
Copy link
Copy Markdown
Contributor Author

Maybe this should be split into:

  • update to lsp-types 0.97
  • split SnippetCap into Completion* and Workspace*
  • and after the blocker is released: update to lsp-types 0.98

does that sound good, or do you want to do all three at once and wait for upstream?

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 20, 2026

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants