snippet edit support no longer experimental#22088
snippet edit support no longer experimental#22088BenjaminBrienen wants to merge 1 commit intorust-lang:masterfrom
Conversation
|
The switch from |
|
I don't think replacing |
|
I thought that making it a boolean would bring it in-line with all the other capability switches. |
|
Given that we already have it typed, I'd prefer that we don't do that. We can make the other options typed, if you want. |
903b5c9 to
2fa2f92
Compare
|
I split SnippetCap into Workspace and Completion variants because they are actually based on two different things and avoiding mixing them using the type system seems like it would be the "whole point", so to speak. |
This comment has been minimized.
This comment has been minimized.
2fa2f92 to
9c4edfc
Compare
This comment has been minimized.
This comment has been minimized.
|
I'm sorry that the Uri migration is mixed in |
|
Maybe this should be split into:
does that sound good, or do you want to do all three at once and wait for upstream? |
7083511 to
9109d30
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
blocked on gluon-lang/lsp-types#311