createHeadlessForm and mutation of initialValues

[denatys]

I noticed a rather unexpected thing for createHeadlessForm, if you pass initialValues to it, they change internally, which can be undesirable behavior

[sandrina-p]

Hi @denatys, nice catch! That's a bug indeed, it should not mutate the passed initialValues. PRs are welcome! 🙏

[Girishbari]

Hey @sandrina-p @denatys, I don't see that it is reproducible. Could you share the steps or something to reproduce it

[sandrina-p]

Hi @Girishbari! A good way to reproduce it is by writing a test. You pass some initialValues to createHeadlessForm(), and then assert they are still the same value. You'll notice they are not. For example:

const schema ={
  "properties": {
    "a": {
      "type": "string",
      "default": "foo"
    },
    "b": {
      "type": "string",
    },
  }
}

const initialValues = {};

createHeadlessForm(schema, { initialValues })

console.log(initialValues); // it will be mutated to { a: "foo" }

You'll find this mutation at the helper getPrefillValues().

Btw, this bug is only in v0, fixed in v1

[Girishbari]

Got it @sandrina-p, raised the PR

[vishwansh01]

Hi @sandrina-p
Can I take up this issue ?

[sandrina-p]

@vishwansh01 v0 is deprecated, we now only invest time in v1. If you are facing this bug, I recommend you upgrade to v1

[denatys]

If in v1 we are don’t have mutations of initial values I can close issue after confirmation