gh-148735: Fix a UAF in Element.findtext()#148738
Open
StanFromIreland wants to merge 3 commits intopython:mainfrom
Open
gh-148735: Fix a UAF in Element.findtext()#148738StanFromIreland wants to merge 3 commits intopython:mainfrom
Element.findtext()#148738StanFromIreland wants to merge 3 commits intopython:mainfrom
Conversation
`Element.findtext()`
picnixz
reviewed
Apr 19, 2026
picnixz
reviewed
Apr 22, 2026
Member
picnixz
left a comment
There was a problem hiding this comment.
All the occurrences you change are of the form (get borrowed) followed by (incref) right? if so, it is ok to change it to (get strong ref) but otherwise we may have un-necessary incref/decref. Currently XML is not FT-safe but if we (I) want to make it so, we should avoid incref/decref in hot paths
Member
The number of incerfs/decrefs remains the same. They are not unnecessary. |
Member
|
Yeah I was not sure about this as I am on mobile. Thanks for checking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a regression introduced by c57623c.
cpython/Modules/_elementtree.c
Line 575 in ae55e9c
Element.findtext()when tag__eq__mutates parent #148735