Split off endianness and version-dependent conversion tests - #213
Merged
davecramer merged 1 commit intoSep 13, 2026
Merged
Conversation
result-conversions.out had 4 different output variants and it was easy to forget to update _1 _2 _3.out when something changed. Split the parts that actually differ (hex representation on big-endian systems and floating point representation on pre-PG12 servers) into a separate file so result-conversions.out is left with only one variant. This fixes the test on big-endian that was missed in 4a5a0e7. Assisted-By: Kimi
Contributor
Author
|
Failing Debian build of 18.00.0003: https://buildd.debian.org/status/logs.php?pkg=psqlodbc&ver=1%3A18.00.0003-1 |
Contributor
|
I wanted to add this comment. So should we add a debian build to the CI to avoid these surprises ? |
Contributor
Author
|
Debian packages build from release tarballs, and the buildds are not meant for CI-style builds. So I guess we need to live with the surprises, unless someone figures out a way to hook some big-endian arch into github CI. But the problems have been pretty rare in the past, so it might not be worth it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
result-conversions.out had 4 different output variants and it was easy to forget to update _1 _2 _3.out when something changed. Split the parts that actually differ (hex representation on big-endian systems and floating point representation on pre-PG12 servers) into a separate file so result-conversions.out is left with only one variant.
This fixes the test on big-endian that was missed in 4a5a0e7.
Assisted-By: Kimi