close
Skip to content

Global scopes and look for token with broader scope in the cache#633

Merged
jonesbusy merged 1 commit intooras-project:mainfrom
jonesbusy:feature/global-scopes
Mar 8, 2026
Merged

Global scopes and look for token with broader scope in the cache#633
jonesbusy merged 1 commit intooras-project:mainfrom
jonesbusy:feature/global-scopes

Conversation

@jonesbusy
Copy link
Copy Markdown
Collaborator

@jonesbusy jonesbusy commented Mar 8, 2026

Description

Handle global scope like aws and lookup for broader scope (typically a PUSH when we pull)

Testing done

CI

Submitter checklist

  • I have read and understood the CONTRIBUTING guide
  • I have run mvn license:update-file-header, mvn spotless:apply, pre-commit run -a, mvn clean install before opening the PR

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 8, 2026

Codecov Report

❌ Patch coverage is 84.93151% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.35%. Comparing base (756891c) to head (2c6b8c2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/main/java/land/oras/auth/TokenCache.java 84.44% 4 Missing and 3 partials ⚠️
src/main/java/land/oras/auth/Scopes.java 78.94% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #633      +/-   ##
============================================
+ Coverage     86.67%   87.35%   +0.67%     
- Complexity      879      902      +23     
============================================
  Files            43       43              
  Lines          2695     2752      +57     
  Branches        344      351       +7     
============================================
+ Hits           2336     2404      +68     
+ Misses          215      200      -15     
- Partials        144      148       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonesbusy jonesbusy force-pushed the feature/global-scopes branch 5 times, most recently from 6f05bdd to 4cce952 Compare March 8, 2026 13:53
Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>
@jonesbusy jonesbusy force-pushed the feature/global-scopes branch from 4cce952 to 2c6b8c2 Compare March 8, 2026 13:56
@jonesbusy jonesbusy added the enhancement New feature or request label Mar 8, 2026
@jonesbusy jonesbusy marked this pull request as ready for review March 8, 2026 14:08
@jonesbusy jonesbusy merged commit 79f879c into oras-project:main Mar 8, 2026
8 checks passed
@jonesbusy jonesbusy deleted the feature/global-scopes branch March 8, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant