Add @@@ppxlib.inline.end, deprecate @@@deriving.end#594
Conversation
Signed-off-by: Carl Eastlund <ceastlund@janestreet.com>
NathanReb
left a comment
There was a problem hiding this comment.
How about first having a version that supports both, then, in a subsequent release, do the deprecation? That would allow a smoother migration scenario.
I'd be okay to merge the code as it is if we simply always enable the flag.
|
There's very little code affected by this, and it's mostly jane street code that has already switched over internally. A two-phase process seems like overkill. |
|
I'm not sure how to read this (Note an ocaml.org tutorial mentioning Sherlodoc finds less results. |
|
Okay, I changed it to undeprecated by default. I also added some tests of the behavior, and of the flag to deprecate/undeprecate. |
…o allow it. Signed-off-by: Carl Eastlund <ceastlund@janestreet.com>
Signed-off-by: Carl Eastlund <ceastlund@janestreet.com>
… and undeprecated behavior. Signed-off-by: Carl Eastlund <ceastlund@janestreet.com>
86bcda3 to
e1368c8
Compare
…r without patdiff. Signed-off-by: Carl Eastlund <ceastlund@janestreet.com>
NathanReb
left a comment
There was a problem hiding this comment.
Awesome, thanks!
Sorry for the hassle, I'll take care of swapping the swapping the flag for the +1 release to make it deprecated by default!
CHANGES: ### 5.4 Support - Add initial OCaml 5.4 support (ocaml-ppx/ppxlib#570, @patricoferris, @NathanReb) ### Other Changes - Add `Longident.to/of_compiler` to astlib to simplify maintenance of ppx-es that interacts with other parts of the compiler-libs such as the type checker. (ocaml-ppx/ppxlib#603, @NathanReb) - Fix a bug where some infix operators such as `mod` would be printed as raw identifiers by our `Pprintast`. (ocaml-ppx/ppxlib#601, @NathanReb) - Fix 5.2 -> 5.3 migration of constants. Those used to always have a `none` location which can lead to unhelpful error messages. (ocaml-ppx/ppxlib#569, @NathanReb) - Add a new context-free rule type that replaces AST nodes that have the registered attributes attached to them. (ocaml-ppx/ppxlib#574, @Skepfyr) - Allow users to derive code from module bindings and module declarations (ocaml-ppx/ppxlib#576, @patricoferris) - Expose `Ppxlib.Location.Error.t = Astlib.Location.Error.t` (ocaml-ppx/ppxlib#593, @ceastlund) - Add `@@@ppxlib.inline.end`, deprecate `@@@deriving.end`. (ocaml-ppx/ppxlib#594, @ceastlund) - Clean the AST of any ppxlib migration attributes whenever printing using Pretty_print mode and the use_compiler_pp flag. (ocaml-ppx/ppxlib#598, @patricoferris) - Add custom printer support to `pp_ast` functions via the `?printer` config parameter. (ocaml-ppx/ppxlib#526, @pedrobslisboa)
Replace
deriving.endwithinline.endso the attribute makes more sense in the context of, e.g.,@@expand_inline. Deprecate the old name for the attribute, with a command-line flag to allow it.