[UK] Use database for co-ordinate transformation.#299
Merged
Conversation
Contributor
|
Looks good to me - just a couple of things:
|
f75f25e to
5e12583
Compare
If the application is running on a server with GDAL 1.9 (and maybe 1.8), its OSGB co-ordinate transformation can be up to a few metres out. As we use the transformation by the database when saving new coordinates, also use it when fetching so we can match and display accurate information. https://trac.osgeo.org/gdal/ticket/4597 is the GDAL ticket that explains that it is fixed in GDAL 1.10.
5e12583 to
e8294e3
Compare
Member
Author
|
I've added a link to the GDAL trac ticket and tests (the GB one I've validated against other data, the NI one doesn't agree but as GDAL + postgres match I'm going to go with that anyway). I've then fixed some other test thing (order mattered and tests failed on firefly) and a co-ord display issue. |
A couple of tests were e.g. altering mapit.models.countries and not setting it back, and another two would only pass if COUNTRY was set to 'GB'. Set those to skip, and restore original settings.
No idea why the latitude in the wmflabs link was being limited to 1 decimal place previously!
e8294e3 to
130a8d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the application is running on a server with GDAL 1.9 (and maybe 1.8),
its OSGB co-ordinate transformation can be up to a few metres out. As we
use the transformation by the database when saving new coordinates, also
use it when fetching so we can match and display accurate information.