Changes after a fresh import#225
Closed
symroe wants to merge 3 commits into
Closed
Conversation
Without this, the initial Boundary-Line import (as laid out in the documentation) fails due to the incorrect ID that the patch fixes.
Member
|
Patch IDs - ah, because if it's a first import you can't use the 2015-10 control file as is, I see. As these patches might only apply to the 2015-10 edition but will always be correct, it's okay to have them in the first use file. It would be good if this could be edited to state the edition of Boundary-Line that these patch lines exist for. Now fixed on master CSV - sure, happy to add this, but this is a very old one off script from 2010, the data it uses won't have been updated since then; just checking you realise that. Break lines - We have a setup.cfg in the repository root that sets our max line length to 119, so this isn't necessary, thanks :) |
Member
|
First fixed differently, second cherry picked, third unnecessary, so this is done, thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are 3 commits I made whilst importing the data from scratch.
Patch incorrect IDs in first-gss control fileis becausepatch_boundary_lineis needed on the initial import, however the patch function was missing from thefirst-importfile.Open CSV files with the correct encodingmight just be an issue with python 3, but I think it's backwards compatible.And the last one is just a small pep8 update that I thought should be it's own commit.