close
Skip to content

Add Italian application.#153

Merged
dracos merged 3 commits into
masterfrom
openpolis-master
Dec 18, 2014
Merged

Add Italian application.#153
dracos merged 3 commits into
masterfrom
openpolis-master

Conversation

@dracos
Copy link
Copy Markdown
Member

@dracos dracos commented Dec 18, 2014

This PR contains most of #147. The differences are:

  • It factors out the find parents code to a shared file between the GB and IT apps.
  • Minor flake8 fixes.
  • Rebased and squashed with minor commit renames.
  • It doesn't include fc0880d (already in master), 2bb188e (now hopefully fixed on master), or bdf7209 (hopefully unnecessary).

@stevenday
Copy link
Copy Markdown
Contributor

This looks good generally.

I'm not sure if it's possible, but maybe the new FindParentsCommand should raise some kind of error if you haven't set parentmap? You could add a getter method and check for the property or raise NotImplementedError() or something? It seems like something that might trip people up in the future and the error message will be a bit confusing as it stands at the moment.

@dracos dracos merged commit b0818e5 into master Dec 18, 2014
@dracos dracos deleted the openpolis-master branch December 22, 2015 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants