Scopes "module" or "class" circumvent the blocking

[ymyke]

Thanks for the great plugin!

I noticed the following:

Example 1:

import requests

def test():
    requests.get("http://httpbin.org/status/200")

This will raise SocketBlockedError, as expected.

Example 2:

import pytest
import requests

@pytest.fixture # scope == "function" by default
def getit():
    requests.get("http://httpbin.org/status/200")

def test(getit):
    pass

This will also raise the SocketBlockedError. Also as expected.

Example 3:

import pytest
import requests

@pytest.fixture(scope="module") # <== Notice the different scope!
def getit():
    requests.get("http://httpbin.org/status/200")

def test(getit):
    pass

This will pass. No exception.

To me, this was unexpected and lead to some debugging headaches.

Is this intended behavior or a bug? Is there a way to make the plugin also prevent cases such as this one?

[ymyke]

Looking into the pytest socket code and the pytest documentation, this seems to be expected behavior:

• socket_disabled is a normal fixture, i.e. with "function" scope.
• Fixture resolution order states that higher order fixtures are resolved before lower order ones.

Hence, in example 3 above the get call will happen before the socket_disabled fixture.

Maybe worth mentioning this in the documentation.

[miketheman]

Hi @ymyke !
Thanks for the diagnosis, and report.

Where in the documentation would you have expected to find this kind of specific behavior definition?

[ymyke]

Maybe in a separate section called "Caveats" or "Gotchas"? Or in an FAQ section? Maybe with a title such as "Network access in some of my fixtures work despite disabling sockets, why?".

[miketheman]

@ymyke Please check out #61 and let me know what you think!