close
Skip to content

Add token for Dashboard url when running aspire ps#16165

Merged
JamesNK merged 4 commits intomicrosoft:mainfrom
divyeshio:issue-16028
Apr 15, 2026
Merged

Add token for Dashboard url when running aspire ps#16165
JamesNK merged 4 commits intomicrosoft:mainfrom
divyeshio:issue-16028

Conversation

@divyeshio
Copy link
Copy Markdown
Contributor

@divyeshio divyeshio commented Apr 14, 2026

Description

Fixes #16028

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

After changes :

image

Copilot AI review requested due to automatic review settings April 14, 2026 18:21
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates aspire ps table output so the displayed Dashboard URL includes the full URL (including login token), aligning the visible value with the hyperlink target and addressing the request in #16028.

Changes:

  • Update ps table rendering to display the full dashboard URL (path + query) instead of only scheme/authority.
  • Add a unit test asserting that the table output includes the dashboard login token.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
tests/Aspire.Cli.Tests/Commands/PsCommandTests.cs Adds coverage to ensure aspire ps table output includes the tokenized dashboard URL.
src/Aspire.Cli/Commands/PsCommand.cs Changes the displayed dashboard URL in table format to use the full absolute URI.

Comment thread src/Aspire.Cli/Commands/PsCommand.cs Outdated
Comment thread tests/Aspire.Cli.Tests/Commands/PsCommandTests.cs Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16165

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16165"

Comment thread src/Aspire.Cli/Commands/PsCommand.cs Outdated
@JamesNK JamesNK enabled auto-merge (squash) April 15, 2026 04:49
divyeshio and others added 4 commits April 15, 2026 19:50
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@JamesNK JamesNK merged commit 70e8edd into microsoft:main Apr 15, 2026
550 of 553 checks passed
@github-actions github-actions bot added this to the 13.3 milestone Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aspire ps does not show dashboard login token

3 participants