Implement table widget for Ecto queries#34
Merged
jonatanklosko merged 5 commits intomainfrom Jul 23, 2021
Merged
Conversation
Member
Author
|
Here is a self-contained example notebook. |
josevalim
reviewed
Jul 22, 2021
josevalim
reviewed
Jul 22, 2021
josevalim
reviewed
Jul 22, 2021
josevalim
reviewed
Jul 22, 2021
josevalim
reviewed
Jul 22, 2021
josevalim
reviewed
Jul 22, 2021
josevalim
reviewed
Jul 22, 2021
Contributor
josevalim
left a comment
There was a problem hiding this comment.
Comments added. We should probably devise a testing scheme where we emulate the messages to handle some of the corner cases.
josevalim
reviewed
Jul 23, 2021
jonatanklosko
commented
Jul 23, 2021
Co-authored-by: José Valim <jose.valim@dashbit.co>
josevalim
approved these changes
Jul 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly useful with Kino as a dev dependency in Mix projects, but may also be useful for Ecto tutorial notebooks.
kino_ecto.mp4