[11.x] Add Skip middleware for Queue Jobs#52645
Merged
taylorotwell merged 3 commits intolaravel:11.xfrom Sep 6, 2024
Merged
Conversation
Contributor
|
i'd say use "when" instead of "if". This is more in line with other parts of laravel. (Conditionable trait) |
Contributor
Author
|
@henzeb Thanks for the suggestion! I'm open to using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a pattern where I was frequently using closure middleware to skip some jobs after they were queued (some of my jobs are delayed):
So, I created a Skip middleware for Queue Jobs to replace those use cases:
I thought it might be useful to include this in the core. This middleware can be used by passing a bool or a closure: