ui: restyle feature tabs dots#2860
Open
tomaszantas wants to merge 7 commits intolangfuse:mainfrom
Open
Conversation
Main upstream
|
@tomaszantas is attempting to deploy a commit to the langfuse Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restyle FeaturesTabs indicators (dots)
Disclaimer: Experimental PR review
Greptile Summary
This PR restyled the feature-tab dot indicators: inactive dots shrink to 5×5 px squares and the active dot expands to a wider stripe-patterned pill (
w-10,with-stripes-alt) with a smoothmotion.span layoutwidth animation. Supporting changes include removing thegap-1.5from the container (spacing is now provided by the buttons'p-1padding), addingcursor-pointer, and importing thecnutility.Confidence Score: 5/5
Safe to merge — purely visual restyling with no logic or data changes.
All findings are P2 style suggestions. The only note is that sibling buttons aren't wrapped in motion.button, which may cause a subtle snap on tab change, but this doesn't break functionality.
No files require special attention.
Important Files Changed
motion.span layoutfor animated width transitions;gap-1.5removed from container (spacing now comes from button padding);cursor-pointeradded;cnutility imported.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Tab clicked] --> B{isActive?} B -- Yes --> C["motion.span: w-10 + with-stripes-alt\n(animated expand via layout)"] B -- No --> D["motion.span: w-[5px] + bg-line-structure\n(animated shrink via layout)"] C --> E[Parent button snaps width — not a motion.button] D --> E E --> F[Sibling buttons reposition without animation]Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "clean up" | Re-trigger Greptile