close
Skip to content

ci: add path filters to skip KinD e2e on unrelated changes#9045

Open
Ankitsinghsisodya wants to merge 2 commits intoknative:mainfrom
Ankitsinghsisodya:ci/path-filters
Open

ci: add path filters to skip KinD e2e on unrelated changes#9045
Ankitsinghsisodya wants to merge 2 commits intoknative:mainfrom
Ankitsinghsisodya:ci/path-filters

Conversation

@Ankitsinghsisodya
Copy link
Copy Markdown
Contributor

@Ankitsinghsisodya Ankitsinghsisodya commented Apr 22, 2026

Summary

  • Adds paths filters to the pull_request trigger in kind-e2e.yaml
  • The KinD e2e matrix (3 test suites × 2 k8s versions) currently fires on every PR regardless of what changed; restricting it to paths that can actually affect runtime behaviour avoids wasting ~6 parallel runner-hours on documentation or tooling-only PRs

Paths that trigger the workflow:

  • **/*.go — any Go source change
  • go.mod / go.sum — dependency changes
  • config/** — Knative config YAMLs
  • test/** — test helpers and fixtures
  • .github/workflows/kind-e2e.yaml — the workflow file itself

Note: e2e-tests is not a required status check on this repo (Prow handles gating via conformance-tests_eventing_main etc.), so a skipped run on docs-only PRs does not block merging.

Test plan

  • Confirm e2e workflow is skipped for a docs-only PR
  • Confirm e2e workflow runs for a PR touching .go files

The KinD e2e matrix (3 test suites × 2 k8s versions) currently fires on
every PR regardless of what changed. Restricting it to paths that can
actually affect runtime behaviour — Go source, go.mod/sum, config/,
test/, and the workflow file itself — avoids wasting ~6 parallel
runner-hours on documentation or tooling-only changes.

The e2e-tests check is not a required status check on the upstream
repo (Prow handles gating), so a skipped run on docs-only PRs does
not block merging.
Copilot AI review requested due to automatic review settings April 22, 2026 18:31
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 22, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ankitsinghsisodya
Once this PR has been reviewed and has the lgtm label, please assign leo6leo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 22, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 22, 2026

Hi @Ankitsinghsisodya. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot requested review from Cali0707 and pierDipi April 22, 2026 18:31
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds path-based filtering to the KinD e2e GitHub Actions workflow so it only runs on PRs that change runtime-relevant files, reducing unnecessary CI usage.

Changes:

  • Add paths filters to the pull_request trigger for the KinD e2e workflow
  • Restrict workflow execution to Go sources, Go deps, config, tests, and the workflow file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/kind-e2e.yaml
GitHub Actions path globs are minimatch-based; **/*.go is the
unambiguous pattern for any .go file under the repo tree.
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.48%. Comparing base (7c4c338) to head (953a82d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9045      +/-   ##
==========================================
- Coverage   50.51%   50.48%   -0.03%     
==========================================
  Files         409      409              
  Lines       27505    27505              
==========================================
- Hits        13894    13887       -7     
- Misses      12749    12756       +7     
  Partials      862      862              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants