Fix dd integration tests, add MUST-tier conv= coverage#34
Open
Conversation
Five tests compared against macOS /usr/bin/dd which produced empty output, causing false failures. Replaced with hardcoded expected values matching GNU dd behavior. Added 9 integration tests for MUST-tier conv= values: sync (NUL padding), sync (full block), notrunc/truncate contrast, fsync, osync, ascii, ebcdic, ibm, and noerror. Total coverage went from 22 to 40 tests with all passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/usr/bin/dd(which produced empty output). Replaced with hardcoded expected values matching GNU dd behavior.conv=values:sync(NUL padding + full block),notrunc/truncate contrast,fsync,osync,ascii,ebcdic,ibm, andnoerror.Context
The code audit found that 11 MUST-tier
conv=values had zero integration tests. Investigation revealed thatconv=sync,conv=notrunc, andconv=ibmwere already implemented correctly in the source code, but the integration tests that were supposed to verify them compared against macOS system dd output, which produced empty results.Test plan
just fmt-- no changeszig build test --summary all-- all unit tests passjust it-util dd-- 40/40 integration tests pass