Add WireGuard VPN WebUI REST support (list + toggle) - #266
Conversation
|
Thanks for the PR. Please keep pull-requests small, like mentioned in contibuting.md. Can it be that you have used AI to generate code and the PR description? In case you use AI helpers, don't let them write code, but let them help you write code (like a pair programming companion). You are also in the v2-development branch (still under development (sic) with a lot of refacturing!). So for a commit please don't run ruff on code not related to the PR. Some comments about the other files (partly already mentioned in your note):
Here is the roadmap from my point of view:
Hopefully I can handle this in a fortnight. Then you can care about the new library module and the according tests (two files). A note: for me the term WebUI seems to be wrong. This implies an interface designed for human users. This is not what happens here. I suggest to not use this term. So far my first impressions. |
482d7fb to
177ffe1
Compare
Hi kbr,
Thanks a lot for your suggestions. This PR keeps the change minimal-invasive in fritzconnection: it only adds what WireGuard WebUI REST needs and reuses existing core mechanisms (SID login/challenge + REST plumbing) instead of introducing new abstractions.
This PR enables:
Why the core additions are needed:
Auth/error semantics:
Included changes (core-only):
Tests/verification: