reduce ticks stemming from withCleanup#4526
Merged
yaacovCR merged 2 commits intographql:nextfrom Jan 26, 2026
Merged
Conversation
replace withCleanup() with more targeted withConcurrentAbruptClose(). next() calls are no longer wrapped, reducing extra ticks = refactors mapAsyncIterable to use the more targeted function = refactors IncrementalPublisher to also perform required clean up on a normal close.
|
@yaacovCR is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
prior to withCleanup changes, this test was actually being triggered by the rejected promise from the next() call, it's working correctly after this change, but it can still be streamlined
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Jan 27, 2026
replace withCleanup() with more targeted withConcurrentAbruptClose(). next() calls are no longer wrapped, reducing extra ticks = refactors mapAsyncIterable to use the more targeted function = refactors IncrementalPublisher to also perform required clean up on a normal close. * this change also alters the behavior of a stream test to no longer pass spuriously and allows it to be further streamlined
yaacovCR
added a commit
that referenced
this pull request
Feb 22, 2026
replace withCleanup() with more targeted withConcurrentAbruptClose(). next() calls are no longer wrapped, reducing extra ticks = refactors mapAsyncIterable to use the more targeted function = refactors IncrementalPublisher to also perform required clean up on a normal close. * this change also alters the behavior of a stream test to no longer pass spuriously and allows it to be further streamlined
yaacovCR
added a commit
that referenced
this pull request
Feb 22, 2026
replace withCleanup() with more targeted withConcurrentAbruptClose(). next() calls are no longer wrapped, reducing extra ticks = refactors mapAsyncIterable to use the more targeted function = refactors IncrementalPublisher to also perform required clean up on a normal close. * this change also alters the behavior of a stream test to no longer pass spuriously and allows it to be further streamlined
yaacovCR
added a commit
that referenced
this pull request
Feb 23, 2026
replace withCleanup() with more targeted withConcurrentAbruptClose(). next() calls are no longer wrapped, reducing extra ticks = refactors mapAsyncIterable to use the more targeted function = refactors IncrementalPublisher to also perform required clean up on a normal close. * this change also alters the behavior of a stream test to no longer pass spuriously and allows it to be further streamlined
yaacovCR
added a commit
that referenced
this pull request
Feb 24, 2026
replace withCleanup() with more targeted withConcurrentAbruptClose(). next() calls are no longer wrapped, reducing extra ticks = refactors mapAsyncIterable to use the more targeted function = refactors IncrementalPublisher to also perform required clean up on a normal close. * this change also alters the behavior of a stream test to no longer pass spuriously and allows it to be further streamlined
yaacovCR
added a commit
that referenced
this pull request
Feb 24, 2026
replace withCleanup() with more targeted withConcurrentAbruptClose(). next() calls are no longer wrapped, reducing extra ticks = refactors mapAsyncIterable to use the more targeted function = refactors IncrementalPublisher to also perform required clean up on a normal close. * this change also alters the behavior of a stream test to no longer pass spuriously and allows it to be further streamlined
yaacovCR
added a commit
that referenced
this pull request
Feb 24, 2026
replace withCleanup() with more targeted withConcurrentAbruptClose(). next() calls are no longer wrapped, reducing extra ticks = refactors mapAsyncIterable to use the more targeted function = refactors IncrementalPublisher to also perform required clean up on a normal close. * this change also alters the behavior of a stream test to no longer pass spuriously and allows it to be further streamlined
yaacovCR
added a commit
that referenced
this pull request
Feb 24, 2026
replace withCleanup() with more targeted withConcurrentAbruptClose(). next() calls are no longer wrapped, reducing extra ticks = refactors mapAsyncIterable to use the more targeted function = refactors IncrementalPublisher to also perform required clean up on a normal close. * this change also alters the behavior of a stream test to no longer pass spuriously and allows it to be further streamlined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace withCleanup() with more targeted withConcurrentAbruptClose().
next() calls are no longer wrapped, reducing extra ticks
= refactors mapAsyncIterable to use the more targeted function
= refactors IncrementalPublisher to also perform required clean up on a normal close.