docs: editorial on abstract types page#4394
Merged
Conversation
JoviDeCroock
approved these changes
May 17, 2025
Contributor
|
@benjie This has conflicts since my ESM transition |
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editorial on #4393
Excellent guide! The main correction was that in GraphQL v16 support for returning the object type from
resolveTypewas turned into an error, and it is removed in v17 - strings are the only supported approach going forward. I also made some more of the text more accurate and added a little detail in a couple places. Overall, an excellent resource!I would like to see all the code in GraphQL.js using ESM though. Something to chat with @JoviDeCroock about, but now Node 22 is the LTS version and it supports
require(ESM), writing our code samples in ESM will be much more natural and also allows for copy/paste into TypeScript without requiring editing.cc @sarahxsanders