[2.x] chore(js): remove Array.prototype.flat polyfill#4483
Merged
Conversation
Array.prototype.flat has been supported natively since Chrome 69, Firefox 62, Safari 12 (2018), and Edge 79. The polyfill was originally added for iOS < 12 support, which is no longer a target for Flarum 2.x. Removing it saves ~8.5 KiB from the bundled forum.js output.
cc88591 to
2741b93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Array.prototype.flathas been natively supported since Chrome 69, Firefox 62, Safari 12 (2018), and Edge 79. The polyfill was added for iOS < 12 support, which is no longer a target for Flarum 2.x.Flagged by Google Lighthouse as 8.5 KiB of unnecessary legacy JavaScript in the
forum.jsbundle.Changes
src/common/utils/arrayFlatPolyfill.tssrc/common/index.tsNo call sites need updating — the three usages of
.flat()in core (Application.tsx×2,PaginatedListState.ts×1) rely on the native implementation which is available on all supported browsers.Test plan
yarn buildinframework/core/js/completes without errorsarrayFlatPolyfillis gone