Conversation
The DiscussionList-update banner was broken in two ways: 1. The `Button--block` CSS class no longer exists after d2129e6 converted it to a parametric LESS mixin. Add `.Button--block()` to `.DiscussionList-update` in forum.less so the button gets `display: flex; width: 100%` again. 2. The banner was injected via `vdom.children.unshift()` — a 1.x-era pattern that mutates the raw vdom array. Replace it with a proper `extend(IndexPage.prototype, 'contentItems', ...)` at priority 95 (between the toolbar at 100 and the discussion list at 90). Move all state and websocket bindings from DiscussionList lifecycle hooks to IndexPage, which is the correct owner since the banner is a page-level concern. Remove the dead `this.addDiscussion` method that was assigned in oninit but never wired to an extend() call.
imorland
added a commit
that referenced
this pull request
Mar 21, 2026
imorland
added a commit
that referenced
this pull request
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Banner width regression:
Button--blockstopped working as a CSS class after d2129e6 converted it to a parametric LESS mixin (.Button--block()). Fix by calling.Button--block()directly in.DiscussionList-updateinforum.less.1.x-era vdom mutation replaced: The banner was injected via
vdom.children.unshift(), which mutates the raw Mithril vdom array. Replace withextend(IndexPage.prototype, 'contentItems', ...)at priority 95 — sitting between the toolbar (100) and the discussion list (90).State moved to correct owner: All websocket event bindings and the
WebsocketUpdatesinstance have been moved fromDiscussionListlifecycle hooks toIndexPage, which is the right owner since the banner is a page-level concern, not a list-level concern.Dead code removed:
this.addDiscussionwas assigned inoninitbut never wired to anextend()call — removed.Test plan