Merged
Conversation
The symfony/postmark-mailer bridge is already a dependency of flarum/core. This adds a PostmarkDriver to expose it as a selectable mail driver, consistent with the existing Mailgun driver. Supports the server token (required) and an optional message stream setting for Postmark's message streams feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4442.
The
symfony/postmark-mailerbridge is already a dependency offlarum/corebut no driver was ever wired up. This addsPostmarkDriverfollowing the exact same pattern as the existingMailgunDriver.PostmarkDriver— implementsDriverInterfacewithmail_postmark_token(required server token) andmail_postmark_message_stream(optional, for Postmark's message streams feature)MailServiceProvider— registers'postmark' => PostmarkDriver::classin the supported drivers mapcore.yml— adds locale keys:mail_postmark_token_label,mail_postmark_message_stream_label,postmark_heading,postmark_descriptionTest plan
PostmarkDriverTestcovering driver metadata, validation (valid config, missing token, whitespace in token, optional message stream), and transport construction (with and without message stream)postmarkappears in/api/mail/settingsfields with the correct keysMailTestintegration tests continue to pass