[2.x] fix(mentions): prevent crash when tag or group has no icon/color#4447
Merged
[2.x] fix(mentions): prevent crash when tag or group has no icon/color#4447
Conversation
Calling tag.setAttribute('icon', model.icon()) when model.icon() returns
null causes a TypeError in the s9e TextFormatter JS serializer, which
calls .toString() on every attribute value. Coerce null to '' to prevent
the crash.
Fixes #4436
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeError: Cannot read properties of null (reading 'toString')in the composer preview when mentioning a tag or group that has no icon/color setpostFilterTagMentionsandpostFilterGroupMentions,model.icon()/group.icon()return JSnullfor tags without icons. The s9e TextFormatter JS serializer calls.toString()on every attribute value, crashing onnullnullto''with|| ''on all four nullable attributes (icon,colorfor both tags and groups)Closes #4436
Test plan
TagMentionsTest.php: one for a tag with icon, one for a tag without icon — asserts no crash and correct rendering