Evbox Elvi (OCPP): "charger logic error" and "charger out of sync"#29809
Open
premultiply wants to merge 2 commits into
Open
Evbox Elvi (OCPP): "charger logic error" and "charger out of sync"#29809premultiply wants to merge 2 commits into
premultiply wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider adding a short inline comment or central explanation for why
Current.Offeredneeds to be negated (-Current.Offered) for metervalues in this template so future maintainers understand the rationale and don't inadvertently revert it.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a short inline comment or central explanation for why `Current.Offered` needs to be negated (`-Current.Offered`) for metervalues in this template so future maintainers understand the rationale and don't inadvertently revert it.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
This PR adjusts the EVBox Elvi OCPP charger template to change which OCPP MeterValuesSampledData measurands are configured, aiming to address reported “charger logic error” / “charger out of sync” behavior (#29588).
Changes:
- When
meteristrue, setmetervaluesto removeCurrent.Offered,Power.Offered, andSoCfrom evcc’s desired measurands list. - Keep the existing behavior for
meter: falseto configuremetervalues: Current.Offered.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Member
|
Oh nice... maybe add a comment that it does? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29588
Replaces #29652