Yaml: fix decoding empty stream everywhere

[andig]

Fix #29672 (for real)

[sourcery-ai]

Hey - I've found 1 issue, and left some high level feedback:

• In util/yaml/yaml.go, Unmarshal currently calls goyaml.Unmarshal(b, &res), which will pass a pointer to the interface instead of the underlying value; this should likely be goyaml.Unmarshal(b, res) so callers can pass their destination directly.
• Consider extending the util/yaml package to expose Encoder/Decoder helpers (e.g., NewEncoder/NewDecoder) so that call sites like settings.SetYaml can consistently use the wrapper instead of mixing direct goyaml usage with the custom Unmarshal behavior.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In util/yaml/yaml.go, Unmarshal currently calls goyaml.Unmarshal(b, &res), which will pass a pointer to the interface instead of the underlying value; this should likely be goyaml.Unmarshal(b, res) so callers can pass their destination directly.
- Consider extending the util/yaml package to expose Encoder/Decoder helpers (e.g., NewEncoder/NewDecoder) so that call sites like settings.SetYaml can consistently use the wrapper instead of mixing direct goyaml usage with the custom Unmarshal behavior.

## Individual Comments

### Comment 1
<location path="util/yaml/yaml.go" line_range="14-15" />
<code_context>
+}
+
+// Unmarshal invokes unmarshaler, ignoring empty document errors
+func Unmarshal(b []byte, res any) error {
+	err := goyaml.Unmarshal(b, &res)
+	if err != nil && strings.Contains(err.Error(), "no documents in stream") {
+		err = nil
</code_context>
<issue_to_address>
**issue (bug_risk):** Unmarshal is unmarshalling into a copy of `res` instead of the caller’s value

Here `res` should be passed directly to `goyaml.Unmarshal`. Because `res` is already a pointer to the target value, using `&res` gives `Unmarshal` a `*interface{}` (or pointer-to-`any`), so it only populates that temporary rather than the caller’s value. This means the caller observes no changes. Use `goyaml.Unmarshal(b, res)` instead.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}