close
Skip to content

OCPP: handle firmware management events#29507

Merged
andig merged 1 commit into
masterfrom
feat/ocpp-firmware-status
Apr 30, 2026
Merged

OCPP: handle firmware management events#29507
andig merged 1 commit into
masterfrom
feat/ocpp-firmware-status

Conversation

@andig
Copy link
Copy Markdown
Member

@andig andig commented Apr 30, 2026

Adds the OCPP 1.6 FirmwareManagement profile and acknowledges FirmwareStatusNotification and DiagnosticsStatusNotification so chargers no longer trigger NotSupported errors when reporting firmware/diagnostics status (e.g. ABL Pulsar Plus on FW 6.11.25).

Same pattern as #23199 (security profile).

Closes #29495

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Right now the firmware and diagnostics status notifications are simply acknowledged and discarded; consider at least logging the reported status or updating some internal state so that firmware/diagnostics progress can be inspected or acted upon later.
  • If certain firmware or diagnostics statuses are unexpected or undesired (e.g. repeated failures), it might be useful to validate request.Status and apply different handling or warnings rather than treating all notifications identically.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Right now the firmware and diagnostics status notifications are simply acknowledged and discarded; consider at least logging the reported status or updating some internal state so that firmware/diagnostics progress can be inspected or acted upon later.
- If certain firmware or diagnostics statuses are unexpected or undesired (e.g. repeated failures), it might be useful to validate `request.Status` and apply different handling or warnings rather than treating all notifications identically.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@andig andig changed the title ocpp: handle firmware management events OCPP: handle firmware management events Apr 30, 2026
@andig andig added the enhancement New feature or request label Apr 30, 2026
@andig andig enabled auto-merge (squash) April 30, 2026 12:00
@andig andig merged commit 2d2c953 into master Apr 30, 2026
19 checks passed
@andig andig deleted the feat/ocpp-firmware-status branch April 30, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant