Fixes PUN tariff not loading if next day data is not yet available.#29092
Merged
Conversation
… published by GME
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider centralizing the special handling of
ErrPunDataNotAvailable(e.g., insidebackoffPermanentErroror a dedicated helper) so the logic for which errors are treated as permanent is not split between the retry closure and the outer error check. - It may be helpful to expand the comment near the
ErrPunDataNotAvailablehandling to clarify that this specific error is intentionally treated as non-fatal for the overall run (no log, nodonesignal) to avoid retries when next-day data isn’t yet published.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider centralizing the special handling of `ErrPunDataNotAvailable` (e.g., inside `backoffPermanentError` or a dedicated helper) so the logic for which errors are treated as permanent is not split between the retry closure and the outer error check.
- It may be helpful to expand the comment near the `ErrPunDataNotAvailable` handling to clarify that this specific error is intentionally treated as non-fatal for the overall run (no log, no `done` signal) to avoid retries when next-day data isn’t yet published.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29066. The GME website usually doesn't publish data for the next day until 13.00 CET; this slows down the startup because the code keeps retrying before giving up and prevents the tariff to load.
With this fix, when retrieving data for the next day, if the server responds with a 404 error, the code stops trying and loads the tariff only with the data of the current day.