Tariffs: update Pstryk API integration for pricing metrics#28983
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
window_startandwindow_endquery parameters build slightly different timestamp formats (2006-01-02T15vs2006-01-02), which may lead to inconsistent or invalid ISO8601 values; consider aligning both to the sameYYYY-MM-DDTHH:MM:SSZpattern. - The
jqfilter usesselect(.metrics.pricing != null)which will error ifmetricsis missing; consider a safer pattern likeselect((.metrics // {}) | .pricing != null)to make the parsing more robust to partial responses.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `window_start` and `window_end` query parameters build slightly different timestamp formats (`2006-01-02T15` vs `2006-01-02`), which may lead to inconsistent or invalid ISO8601 values; consider aligning both to the same `YYYY-MM-DDTHH:MM:SSZ` pattern.
- The `jq` filter uses `select(.metrics.pricing != null)` which will error if `metrics` is missing; consider a safer pattern like `select((.metrics // {}) | .pricing != null)` to make the parsing more robust to partial responses.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
2 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #28982
Pstryk changed their API since 01.04.2026.
Endpoints used in evcc no longer exist. Updated tariff template to match updated API.
Tested with newest stable binary (https://github.com/evcc-io/evcc/blob/411f194645b522e6221fd7d588e8b57f8c59e628/CONTRIBUTING.md#device-templates) - works.