close
Skip to content

Add switch devices#28803

Merged
andig merged 6 commits into
masterfrom
feat/onoff
Apr 6, 2026
Merged

Add switch devices#28803
andig merged 6 commits into
masterfrom
feat/onoff

Conversation

@andig
Copy link
Copy Markdown
Member

@andig andig commented Apr 3, 2026

Fix #28060

@andig andig added the enhancement New feature or request label Apr 3, 2026
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread api/feature.go Outdated
Comment thread api/feature.go Outdated
Comment thread api/feature.go Outdated
@naltatis
Copy link
Copy Markdown
Member

naltatis commented Apr 4, 2026

@andig what about sgready.go?

@naltatis naltatis assigned andig and unassigned naltatis Apr 4, 2026
@naltatis
Copy link
Copy Markdown
Member

naltatis commented Apr 4, 2026

LGTM otherwise.

@andig
Copy link
Copy Markdown
Member Author

andig commented Apr 4, 2026

@andig what about sgready.go?

Wdym?

@CiNcH83
Copy link
Copy Markdown
Contributor

CiNcH83 commented Apr 4, 2026

@andig what about sgready.go?

Vaillant also hasn't been adapted?

@andig andig enabled auto-merge (squash) April 6, 2026 08:10
@andig andig merged commit cd02ce1 into master Apr 6, 2026
7 checks passed
@andig andig deleted the feat/onoff branch April 6, 2026 08:13
@andig andig restored the feat/onoff branch April 6, 2026 08:15
@RTTTC

This comment was marked as off-topic.

@naltatis

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chargers: add dedicated feature for on/off devices

4 participants