close
Skip to content

Safari: fix scrollbar overlay issue#28605

Merged
andig merged 1 commit into
masterfrom
fix/safari_scroll_overlay
Mar 27, 2026
Merged

Safari: fix scrollbar overlay issue#28605
andig merged 1 commit into
masterfrom
fix/safari_scroll_overlay

Conversation

@naltatis
Copy link
Copy Markdown
Member

@naltatis naltatis commented Mar 27, 2026

Refs #28566

Working around a Safari bug where inline scrollbars are not drawn in layer order.

@naltatis naltatis requested a review from andig March 27, 2026 14:46
@naltatis naltatis added bug Something isn't working ux User experience/ interface labels Mar 27, 2026
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Hiding the scrollbar with opacity: 0 may hurt discoverability and accessibility for keyboard/mouse users; consider a workaround that preserves a visible scrollbar (e.g., adjusting z-index stacking with an inner wrapper or using position/pointer-events) instead of fully hiding it.
  • If this rule is intended to target only Safari’s behavior, consider wrapping it in a WebKit-specific @supports or adding a more explicit browser-guarding approach so other browsers don’t inherit the scrollbar hiding unnecessarily.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Hiding the scrollbar with `opacity: 0` may hurt discoverability and accessibility for keyboard/mouse users; consider a workaround that preserves a visible scrollbar (e.g., adjusting z-index stacking with an inner wrapper or using `position`/`pointer-events`) instead of fully hiding it.
- If this rule is intended to target only Safari’s behavior, consider wrapping it in a WebKit-specific `@supports` or adding a more explicit browser-guarding approach so other browsers don’t inherit the scrollbar hiding unnecessarily.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@andig andig merged commit d7436cd into master Mar 27, 2026
19 checks passed
@andig andig deleted the fix/safari_scroll_overlay branch March 27, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ux User experience/ interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants