Safari: fix scrollbar overlay issue#28605
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Hiding the scrollbar with
opacity: 0may hurt discoverability and accessibility for keyboard/mouse users; consider a workaround that preserves a visible scrollbar (e.g., adjusting z-index stacking with an inner wrapper or usingposition/pointer-events) instead of fully hiding it. - If this rule is intended to target only Safari’s behavior, consider wrapping it in a WebKit-specific
@supportsor adding a more explicit browser-guarding approach so other browsers don’t inherit the scrollbar hiding unnecessarily.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Hiding the scrollbar with `opacity: 0` may hurt discoverability and accessibility for keyboard/mouse users; consider a workaround that preserves a visible scrollbar (e.g., adjusting z-index stacking with an inner wrapper or using `position`/`pointer-events`) instead of fully hiding it.
- If this rule is intended to target only Safari’s behavior, consider wrapping it in a WebKit-specific `@supports` or adding a more explicit browser-guarding approach so other browsers don’t inherit the scrollbar hiding unnecessarily.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #28566
Working around a Safari bug where inline scrollbars are not drawn in layer order.