close
Skip to content

Incorrect hasPrevious/hasNext in GQL cursor pagination when given empty or invalid cursors #3449

Description

@adrian-estuary

The following GQL resolvers unexpectedly return true for hasPrevious / hasNext pages when given invalid or empty cursors. This is because the pagination logic determines these flag values by the existence of the cursor value, instead of inferring the existence of pages from the returned data.

  • connectors
  • dataPlanes
  • liveSpecs
  • publicationHistory
  • storageMapping
  • tenant -> billing -> invoices

storageMappings - hasPrevious unexpectedly true
Image

liveSpecs - same behavior with hasNext in another resolver
Image

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions