minor fixups for config (AI assisted, undergoing review by human co-author, do not review)#21
Draft
daniel-noland wants to merge 4 commits intomainfrom
Draft
minor fixups for config (AI assisted, undergoing review by human co-author, do not review)#21daniel-noland wants to merge 4 commits intomainfrom
daniel-noland wants to merge 4 commits intomainfrom
Conversation
Remove `#![allow(clippy::redundant_closure_for_method_calls)]` and replace all redundant closures with method references throughout the config crate. I actually don't love this particular change because I thought it was fine before. That said, I hate having arguments with the linter a lot more. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Daniel Noland <daniel@githedgehog.com>
Remove `#![allow(clippy::doc_markdown)]` and add backticks around type names in doc comments throughout the config crate. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Daniel Noland <daniel@githedgehog.com>
Remove `#![allow(clippy::missing_errors_doc)]` and add errors doc sections to all public functions returning Result throughout the config crate. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Daniel Noland <daniel@githedgehog.com>
Remove `#![allow(clippy::struct_excessive_bools)]` and add per-struct `#[allow(clippy::struct_excessive_bools)]` annotations on BGP and BMP config structs where booleans directly model protocol flags. The lint removal was actually perfectly fine, but should be done on a per struct level rather than package wide. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Daniel Noland <daniel@githedgehog.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assisted, undergoing review by human co-author, do not review
Seriously. If you aren't an AI or a coauthor don't review this.
DID YOU READ THE DESCRIPTION?
Moved from githedgehog#1379