Add import options for translations upload#81
Merged
andrii-bodnar merged 3 commits intocrowdin:masterfrom Nov 1, 2022
Merged
Conversation
Member
|
@jivjen thanks a lot for your contribution! 🎉 I will pass this PR for a quick test to our QA team and then will come back to you |
Co-authored-by: Andrii Bodnar <29282228+andrii-bodnar@users.noreply.github.com>
Member
|
@jivjen just received the feedback from our QA team. It works perfectly when specifying these import options in the root of the configuration file. But there is an issue when specifying import options for the file groups: files.source=**/values/strings.xml
files.translation=/values-%two_letters_code%/%original_file_name%
files.import-eq-suggestions=true
files.auto-approve-imported=true
files.translate-hidden=trueIn this case, import options are not considered and not passing to the API. |
Member
|
@jivjen probably, here we need an additional check for the import options presence in the The fileBean (file group) import options should have a higher priority than the root config import options |
Member
|
Hi @jivjen, do you need any assistance with this? |
andrii-bodnar
approved these changes
Nov 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR is to add new import options for the translations upload as described in #78