close
Skip to content

Add import options for translations upload#81

Merged
andrii-bodnar merged 3 commits intocrowdin:masterfrom
jivjen:add-import-options-for-translations-upload
Nov 1, 2022
Merged

Add import options for translations upload#81
andrii-bodnar merged 3 commits intocrowdin:masterfrom
jivjen:add-import-options-for-translations-upload

Conversation

@jivjen
Copy link
Copy Markdown
Contributor

@jivjen jivjen commented Oct 6, 2022

Description:

This PR is to add new import options for the translations upload as described in #78

@andrii-bodnar andrii-bodnar linked an issue Oct 6, 2022 that may be closed by this pull request
@andrii-bodnar
Copy link
Copy Markdown
Member

@jivjen thanks a lot for your contribution! 🎉

I will pass this PR for a quick test to our QA team and then will come back to you

Comment thread src/main/java/com/crowdin/client/RequestBuilder.java Outdated
Co-authored-by: Andrii Bodnar <29282228+andrii-bodnar@users.noreply.github.com>
@jivjen jivjen requested a review from andrii-bodnar October 8, 2022 09:13
@andrii-bodnar
Copy link
Copy Markdown
Member

@jivjen just received the feedback from our QA team.

It works perfectly when specifying these import options in the root of the configuration file.

But there is an issue when specifying import options for the file groups:

files.source=**/values/strings.xml
files.translation=/values-%two_letters_code%/%original_file_name%
files.import-eq-suggestions=true
files.auto-approve-imported=true
files.translate-hidden=true

In this case, import options are not considered and not passing to the API.

@andrii-bodnar
Copy link
Copy Markdown
Member

andrii-bodnar commented Oct 17, 2022

@jivjen probably, here we need an additional check for the import options presence in the FileBean fileBean object

The fileBean (file group) import options should have a higher priority than the root config import options

@andrii-bodnar
Copy link
Copy Markdown
Member

Hi @jivjen, do you need any assistance with this?

@andrii-bodnar andrii-bodnar merged commit 2d68a4c into crowdin:master Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New import options for translations upload

2 participants