Unit tests for CrowdinProjectCacheProvider.getInstance()#107
Merged
andrii-bodnar merged 3 commits intocrowdin:masterfrom May 16, 2023
picimako:cache-provider-test
Merged
Unit tests for CrowdinProjectCacheProvider.getInstance()#107andrii-bodnar merged 3 commits intocrowdin:masterfrom picimako:cache-provider-test
andrii-bodnar merged 3 commits intocrowdin:masterfrom
picimako:cache-provider-test
Conversation
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
============================================
+ Coverage 17.46% 19.83% +2.37%
- Complexity 121 143 +22
============================================
Files 42 42
Lines 1936 1942 +6
Branches 232 232
============================================
+ Hits 338 385 +47
+ Misses 1548 1505 -43
- Partials 50 52 +2
|
andrii-bodnar
approved these changes
May 16, 2023
Member
andrii-bodnar
left a comment
There was a problem hiding this comment.
@picimako awesome, thanks a lot for your contribution! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
CrowdinClienttype along with itsMockCrowdinimplementation for tests, so that unit tests don't have to send real HTTP requests to Crowdin.Projectconstructor argument and field ofCrowdin.getInstance()beforeMockCrowdinwere introduced, but kept the changes because it was unused anyway.CrowdinProjectCacheProvider.getInstance().