Fix custom theme colors not applying due to outdated CSS selectors an…#3799
Open
Ganeshbhargav wants to merge 1 commit intocode-charity:masterfrom
Open
Fix custom theme colors not applying due to outdated CSS selectors an…#3799Ganeshbhargav wants to merge 1 commit intocode-charity:masterfrom
Ganeshbhargav wants to merge 1 commit intocode-charity:masterfrom
Conversation
…d YouTube UI changes
Contributor
|
@Ganeshbhargav thanks for the pr!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Custom theme colors (primary/text) were not applying and remained black/white.
Cause
YouTube updated its internal CSS variables and DOM behavior.
The extension relied on the selector:
html[it-theme=custom]
However, this attribute is not consistently present, causing styles to never apply.
Fix
Result
Tested on