fix: [bug] No forced volume in embedded player at first load or ctrl+f5 or#3767
Draft
ledgerpilot wants to merge 1 commit intocode-charity:masterfrom
Draft
fix: [bug] No forced volume in embedded player at first load or ctrl+f5 or#3767ledgerpilot wants to merge 1 commit intocode-charity:masterfrom
ledgerpilot wants to merge 1 commit intocode-charity:masterfrom
Conversation
…dded player at first load or
d4783a9 to
0403173
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1637
What changed
The fix involves two main parts: first, updating the extension's
manifest.jsonto allow its content script to run within YouTube iframes; and second, adding a new JavaScript file that contains the logic to detect the YouTube player in these iframes and apply the user's "forced volume" settings. Since themanifest.jsonfile is not provided in the repository files, I will describe the necessaryFiles modified
js&css/extension/www.youtube.com/player/player-volume.jsDraft PR — please review before merging.