close
Skip to content

Variadic fusion::list. - #84

Merged
djowel merged 7 commits into
boostorg:developfrom
Flast:feature/variadic/list
Jul 1, 2015
Merged

Variadic fusion::list.#84
djowel merged 7 commits into
boostorg:developfrom
Flast:feature/variadic/list

Conversation

@Flast

@Flast Flast commented Jun 22, 2015

Copy link
Copy Markdown
Collaborator

As mentioned in #57, this implementation doesn't support move.
I'll fix it until 1.59 release.

@Flast

Flast commented Jun 22, 2015

Copy link
Copy Markdown
Collaborator Author

Tested:

  • GCC 5.1.1 gnu++98 / gnu++11 / gnu++14
  • Clang 3.6.1 gnu++98 / gnu++11 / gnu++14
  • MSVC 9.0 / 10.0 / 11.0 / 12.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be possible to drop this specialization by simply giving list_to_cons<> a call static member function. Have you considered it?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. I'll drop it.

@Flast
Flast force-pushed the feature/variadic/list branch from 9083752 to 5cceded Compare June 22, 2015 23:39
@Flast

Flast commented Jun 29, 2015

Copy link
Copy Markdown
Collaborator Author

ping?

@djowel

djowel commented Jun 30, 2015

Copy link
Copy Markdown
Collaborator

Looks good to me. @K-ballo ? It's not perfect, but again, we can incrementally improve this.

@K-ballo

K-ballo commented Jul 1, 2015

Copy link
Copy Markdown
Member

There's not much for me to do here, a list like this is inherently recursive and thus compile time inefficient. I'm not going to pretend to understand what the value is in having a compile time fixed size heterogeneous list.

@djowel

djowel commented Jul 1, 2015

Copy link
Copy Markdown
Collaborator

Those are very good points. I've been asking myself that same question too, but this one is historical. Arguably, the value is in push_front, but I'm not sure that is relevant anymore, esp. with Fusion's lazy views. I was thinking about deprecating them, but I don't see the point in doing that either. I'd love to hear your and Flast's thoughts.

@K-ballo

K-ballo commented Jul 1, 2015

Copy link
Copy Markdown
Member

I don't see the point in it, so I'd be fine with taking this PR as-is and deprecating it. I would definitively not include it in a v3 unless someone can think of a reason.

@djowel

djowel commented Jul 1, 2015

Copy link
Copy Markdown
Collaborator

Agreed!

djowel added a commit that referenced this pull request Jul 1, 2015
@djowel
djowel merged commit 00823cc into boostorg:develop Jul 1, 2015
@Flast

Flast commented Jul 1, 2015

Copy link
Copy Markdown
Collaborator Author

I would definitively not include it in a v3 unless someone can think of a reason.

Agreed too!

.o0(If we go to v3, I wonder we implement sequences other than tuple...

@K-ballo

K-ballo commented Jul 1, 2015

Copy link
Copy Markdown
Member

.o0(If we go to v3, I wonder we implement sequences other than tuple...

Map and set would be nice, associative only, non-indexable.

@Flast

Flast commented Jul 1, 2015

Copy link
Copy Markdown
Collaborator Author

Map and set would be nice, associative only, non-indexable.

Ah, yes. I had forgotten those.

@Flast
Flast deleted the feature/variadic/list branch July 1, 2015 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants