Variadic fusion::list. - #84
Conversation
|
Tested:
|
There was a problem hiding this comment.
I think it should be possible to drop this specialization by simply giving list_to_cons<> a call static member function. Have you considered it?
There was a problem hiding this comment.
Indeed. I'll drop it.
9083752 to
5cceded
Compare
|
ping? |
|
Looks good to me. @K-ballo ? It's not perfect, but again, we can incrementally improve this. |
|
There's not much for me to do here, a list like this is inherently recursive and thus compile time inefficient. I'm not going to pretend to understand what the value is in having a compile time fixed size heterogeneous list. |
|
Those are very good points. I've been asking myself that same question too, but this one is historical. Arguably, the value is in push_front, but I'm not sure that is relevant anymore, esp. with Fusion's lazy views. I was thinking about deprecating them, but I don't see the point in doing that either. I'd love to hear your and Flast's thoughts. |
|
I don't see the point in it, so I'd be fine with taking this PR as-is and deprecating it. I would definitively not include it in a v3 unless someone can think of a reason. |
|
Agreed! |
Agreed too! .o0(If we go to v3, I wonder we implement sequences other than tuple... |
Map and set would be nice, associative only, non-indexable. |
Ah, yes. I had forgotten those. |
As mentioned in #57, this implementation doesn't support move.
I'll fix it until 1.59 release.