Fix a race condition in unique_path. - #15
Merged
Merged
Conversation
If two threads call unique_path at the same time for the first time in the program run, both initial calls to CryptAcquireContext can fail. Both threads will then call the function with CRYPT_NEWKEYSET, but only one of these threads can succeed. The other will fail with NTE_EXISTS. This patch makes it so that if a call fails with that error, it will try to call without the flag one more time, in case another thread created the key set in the meantime. This also applies the patch from trac report #7506. Using these additional flags is the right thing to do.
Beman
added a commit
that referenced
this pull request
Aug 28, 2015
Fix a race condition in unique_path.
Contributor
|
Thanks, Sebastian, --Beman |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If two threads call unique_path at the same time for the first time in the program run,
both initial calls to CryptAcquireContext can fail. Both threads will then call the function
with CRYPT_NEWKEYSET, but only one of these threads can succeed. The other will
fail with NTE_EXISTS.
This patch makes it so that if a call fails with that error, it will try to call without the
flag one more time, in case another thread created the key set in the meantime.
This also applies the patch from trac report #7506. Using these additional flags
is the right thing to do.