[Merged by Bors] - Glb textures should use bevy_render to load images#1454
Closed
mockersf wants to merge 4 commits into
Closed
[Merged by Bors] - Glb textures should use bevy_render to load images#1454mockersf wants to merge 4 commits into
mockersf wants to merge 4 commits into
Conversation
Member
Author
|
Fails to build on wasm because module to load images in bevy_render is behind features... Currently, it works as a side effect because, when enabling feature Possible fixes:
What do you think? |
Member
Author
|
after doing some tests, I didn't notice a slowdown of compilation time by removing the feature check so I went this way |
Member
|
Yeah I think you made the right call for "image features". Looking now! |
cart
reviewed
Mar 3, 2021
Member
cart
left a comment
There was a problem hiding this comment.
This is a good change ❤️
Just one small point of discussion
| } | ||
|
|
||
| /// Load a bytes buffer in a [`Texture`], according to type `image_type`, using the `image` crate` | ||
| pub fn buffer_to_texture(buffer: &[u8], image_type: ImageType) -> Result<Texture, TextureError> { |
Member
There was a problem hiding this comment.
Rather than being a floating function, maybe this should be added to Texture? Ex:
Texture::from_buffer(buffer: &[u8], image_type: ImageType) -> Result<Texture, TextureError> { ... }
Member
|
bors r+ |
bors Bot
pushed a commit
that referenced
this pull request
Mar 3, 2021
Fixes #1396 <img width="1392" alt="Screenshot 2021-02-16 at 02 24 01" src="https://user-images.githubusercontent.com/8672791/108011774-1b991a80-7008-11eb-979e-6ebfc51fba3c.png"> Issue was that, when loading an image directly from its bytes in the binary glb file, it didn't follow the same flow as when loaded as a texture file. This PR removes the dependency to `image` from `bevy_gltf`, and load the image using `bevy_render` in all cases. I also added support for more mime types while there. <img width="1392" alt="Screenshot 2021-02-16 at 02 44 56" src="https://user-images.githubusercontent.com/8672791/108011915-674bc400-7008-11eb-83d4-ded96a38919b.png">
|
Pull request successfully merged into main. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1396
Issue was that, when loading an image directly from its bytes in the binary glb file, it didn't follow the same flow as when loaded as a texture file. This PR removes the dependency to
imagefrombevy_gltf, and load the image usingbevy_renderin all cases. I also added support for more mime types while there.