bevy_render: load .spv assets#1104
Merged
Merged
Conversation
Member
|
I fixed hot reloading by removing a special case that disabled "specialization" for spirv. The intent behind the code was to prevent people "incorrectly" specializing spirv (which does nothing) from accidentally compiling multiple instances of the same shader. But i'd rather have hot-reloading work. We can re-add similar logic later if it becomes a real problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shader stage is determined by
spirv_reflect.Hot reloading does not work since the specialized_shaders for spirv-shaders apparently are empty. I'm not sure why that is (I know relatively little about the internals), maybe I can create a follow-up PR once that works as well.