Fix potential bug when using multiple lights.#1055
Merged
Conversation
Member
|
This doesn't work as expected with no lights. Everything is pure-white instead of using the AmbientColor value |
Contributor
Author
|
Whoops! I mixed up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If multiple lights are close enough to the normal line and if any value in the albedo is sufficiently high, we can get values greater than
1.0ono_Target. This will average the influence of all of the lights.If PBR will be delayed by much more, it may be worthwhile to add a distance based weighted average.