close
Skip to content

Fix using docker specific ignore with read-only build context#1349

Merged
JaewonHur merged 9 commits intoapple:mainfrom
JaewonHur:docker-ignore-readonly-context
Apr 20, 2026
Merged

Fix using docker specific ignore with read-only build context#1349
JaewonHur merged 9 commits intoapple:mainfrom
JaewonHur:docker-ignore-readonly-context

Conversation

@JaewonHur
Copy link
Copy Markdown
Contributor

@JaewonHur JaewonHur commented Mar 25, 2026

This PR resolves #1343.
This PR depends on apple/container-builder-shim#72.

Do not create staging directory under build context, but pass dockerignore file bytes to the container-builder-shim.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Motivation and Context

[Why is this change needed?]

Testing

  • Tested locally
  • Added/updated tests
  • Added/updated docs

@github-actions github-actions bot added the cli label Mar 25, 2026
Comment thread Sources/ContainerCommands/BuildCommand.swift Outdated
@JaewonHur JaewonHur merged commit 2ed65b9 into apple:main Apr 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants