Merged
Conversation
- Closes apple#1270. - The current test is a bit baroque. It tries to run `nc`, either to `8.8.8.8:53` or a proxy server port if `HTTP_PROXY` is in the environment. It seems that for an alpine image, a proxy-aware `Dockerfile` and a `RUN apk install curl` directive is a more natural test of "network access".
JaewonHur
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testBuildNetworkAccessfails intermittently in CI #1270.nc, either to8.8.8.8:53or a proxy server port ifHTTP_PROXYis in the environment. It seems that for an alpine image, a proxy-awareDockerfileand aRUN apk install curldirective is a more natural test of "network access".Type of Change
Motivation and Context
Attempt to improve CI stability.
Testing