Merged
Conversation
7 tasks
Contributor
|
Once this is merged, I'll take a stab at the refactoring/creation of the registry client. |
jglogan
requested changes
Feb 11, 2026
Contributor
jglogan
left a comment
There was a problem hiding this comment.
@tico88612 looks good, just minor stuff!
70fd581 to
9db134e
Compare
saehejkang
reviewed
Feb 13, 2026
9db134e to
29e2b23
Compare
7 tasks
96dc684 to
342773f
Compare
342773f to
c12a157
Compare
jglogan
approved these changes
Mar 4, 2026
Contributor
Author
|
I will update the test |
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Align init parameter name with the property name and fix errors in tests. Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
c12a157 to
d80e236
Compare
Contributor
Author
|
@jglogan Fixed. |
jglogan
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Follow up: #1119 (comment)
Testing